Crypto Piggie

Review of ongoing and pending audits for FCMP components, including updates to the tracking spreadsheet, status of specific reviews, and plans for CARROT core and implementation audits. rucknium: IIRC, jberman maintains the linked spreadsheet. Is all the info up to date? jberman: I believe so, but I'll need to circle back with kayabanerve and sgp_ rucknium: I see two ongoning items: "GBP proof review round 2" by @cypher_stack and "helioselene review and audit" by @VeridiseInc . And four blanks: "EC Divisors impl audit", "GSP impl audit", "Torsion check review", and "Integration audit" jberman: Yep, on the two ongoing: I don't recall an update on those. Will follow up rucknium: Thanks, jberman . The spreadsheet only covers FCMP. jeffro256 , can you share info about Carrot reviews and audits? jeffro256: One of the firms may or may not be performing the carrot_core audit pro bono, will wait until they finish on that, or bail, to make it public. Don't want to put pressure on them for free work ;) If that fails, one of the other firms is willing to do the audit for a 40% discount. jberman: Sorry, I do recall Veridise giving their review on helioselene which led to changes that we discussed here too. I'll update the spreadsheet and we'll have a better discussion on FCMP++ research / audit status next week rucknium: jeffro256: Thanks. Is that the last thing that CARROT needs? jeffro256: It depends on if we want to audit carrot_impl before launch. It doesn't contain much crypto code by itself, but it's the code that is called from wallet2 It contains a lot of tx construction logic, device interfaces, tx scanning logic, etc. I wouldn't require it as a blocker for launch, personally, but it would be nice to get around to it at some point. carrot_impl changes a lot, lot faster than carrot_core at this stage of development, so IMO it wouldn't make sense to try to audit it right now. jberman: I think it's reasonable to start with carrot_core with 100% effort / focus as an isolated audit item, and then progress to carrot_impl especially once it's in a more settled state regarding auditing carrot_impl before launch or not, I think that is a decision we can make at a later time if it comes down to it, but for now aim for beginning the carrot_core audit sooner rather than later the sooner the carrot_core audit begins, the better position we're in to have carrot_impl audited before launch anyway jeffro256: Also, a lot of things in carrot_impl can be changed after the fact without breaking backwards compatibility, whereas that isn't the case with carrot_core. Most changes to carrot_core would necessitate a separate scanning path at least rucknium: Sounds good to me. I'll reiterate that I think it would be a good idea to get a third independent review of EC Divisors to complement the @VeridiseInc and @cypher_stack reviews, given how crucial its role is and how challenging the proofs were. I know not everyone agrees with me on that :) jberman: I agree with you on that jeffro256: It would be very parallelizable, which is nice jberman: I will follow up on that as well rucknium: How could we make that a reality? jeffro256: I think that we should start scoping for a FCMP++ integration audit soon rucknium: jberman: Very nice. Thank you, jberman jeffro256: Would like Berman's opinion, of course jberman: jeffro256, I agree, it's one of my very next tasks to start doing jeffro256: I can also start on an outline for that if that helps it along The only Rust code we would need to include in-scope is the FFI bindings, right? jberman: I have some ideas brewing already which I want to get going on soonish too jeffro256, I think that would be reasonable yep jeffro256: I know that for the carrot_core lib audit, forcing myself to put it in a state worth auditing forced me to fix some last wrinkles with it that I had been thinking about for a while jberman: I think let's get unbiased hash to point done and preferable the rename from "global output ids" -> "unified ids", and then it should be in good position to begin auditing jeffro256: alright fair jberman: will probably be able to complete both today libera.monerologs.net/monero…